Bugfix: Extract visitor data from sw.js_data API instead of randomly…#1271
Closed
sheepmax wants to merge 3 commits intoTeamNewPipe:devfrom
Closed
Bugfix: Extract visitor data from sw.js_data API instead of randomly…#1271sheepmax wants to merge 3 commits intoTeamNewPipe:devfrom
sheepmax wants to merge 3 commits intoTeamNewPipe:devfrom
Conversation
6 tasks
Member
|
Thanks for your PR. I used a different approach which has the benefit of getting a visitorData with a specific InnerTube client from two InnerTube endpoints in #1272, so I'm closing this PR in favor of the one I linked. Once again, I thank you for your pull request and I am sorry to have to close it :( |
Author
|
No worries, @AudricV. I mostly wanted a quick fix for myself, your solution looks much more robust of course. If I may ask, I'm very new to this and confused about where to learn about inner API details. How do you do it yourself? |
Member
|
No, that's not something we plan to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1262, visitor data was randomly generated for the iOS client, but this has recently broken. This PR tries to extract this data from
https://www.youtube.com/sw.js_dataas suggested by @gechoto in TeamNewPipe/NewPipe#11980. Works on NewPipe, with the expected behaviour of videos properly loading. Also took it for a spin with a bike ride :)The solution doesn't feel very robust, but further work on parsing the all the data coming from this endpoint is not something I'm knowledgeable about.